search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
528 stars 96 forks source link

Use BaseStatMonitor to implement built-in downloader exception monitor #334

Closed rennerocha closed 2 years ago

rennerocha commented 2 years ago

All built-in monitors should use BaseStatMonitor when possible. So this PR will continue converting them. Also improving the documentation with a bit more details about the monitor.

codecov[bot] commented 2 years ago

Codecov Report

Merging #334 (fa51494) into master (088f801) will decrease coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   74.11%   74.06%   -0.05%     
==========================================
  Files          68       68              
  Lines        3036     3031       -5     
  Branches      466      465       -1     
==========================================
- Hits         2250     2245       -5     
  Misses        723      723              
  Partials       63       63
Impacted Files Coverage Δ
spidermon/contrib/scrapy/monitors.py 98.20% <100.00%> (-0.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 088f801...fa51494. Read the comment docs.