search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
528 stars 96 forks source link

Use BaseStatMonitor to implement built-in item validation monitor #335

Closed rennerocha closed 2 years ago

rennerocha commented 2 years ago

All built-in monitors should use BaseStatMonitor when possible. So this PR will continue converting them. Also improving the documentation with a bit more details about the monitor.

codecov[bot] commented 2 years ago

Codecov Report

Merging #335 (f8ee7ab) into master (99c1d81) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   74.06%   74.04%   -0.03%     
==========================================
  Files          68       68              
  Lines        3031     3028       -3     
  Branches      465      465              
==========================================
- Hits         2245     2242       -3     
  Misses        723      723              
  Partials       63       63
Impacted Files Coverage Δ
spidermon/contrib/scrapy/monitors.py 98.17% <100.00%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99c1d81...f8ee7ab. Read the comment docs.