scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
528 stars 96 forks source link

Replace slackclient with slack-sdk for Slack action #338

Closed ankitjavalkar closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #338 (1f20bf7) into master (7562a67) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   74.04%   74.04%           
=======================================
  Files          68       68           
  Lines        3028     3028           
  Branches      465      465           
=======================================
  Hits         2242     2242           
  Misses        723      723           
  Partials       63       63           
Impacted Files Coverage Δ
spidermon/contrib/actions/slack/__init__.py 56.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7562a67...1f20bf7. Read the comment docs.

rennerocha commented 2 years ago

I tested locally and the changes worked fine. Slack messages are sent as before.

rennerocha commented 2 years ago

Fix #313