search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
528 stars 96 forks source link

Rename module `hubstorage` to `zyte` and update it #344

Closed tcurvelo closed 2 years ago

tcurvelo commented 2 years ago

These changes were originally part of #323.

codecov[bot] commented 2 years ago

Codecov Report

Merging #344 (c9bdb35) into master (4190273) will increase coverage by 0.53%. The diff coverage is 92.15%.

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   74.03%   74.57%   +0.53%     
==========================================
  Files          70       70              
  Lines        3031     3032       +1     
  Branches      465      467       +2     
==========================================
+ Hits         2244     2261      +17     
+ Misses        724      705      -19     
- Partials       63       66       +3
Impacted Files Coverage Δ
spidermon/utils/zyte.py 92.00% <92.00%> (ø)
spidermon/contrib/scrapy/extensions.py 85.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4190273...c9bdb35. Read the comment docs.

rennerocha commented 2 years ago

You got a drop in coverage probably because you kept spidermon/utils/hubstorage.py. As you were renaming the module you should use git mv spidermon/utils/hubstorage.py spidermon/utils/zyte.py, so we keep the history of the file. I believe that if you remove that now, git will understand that it was just a rename.