scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
528 stars 96 forks source link

Improve not configured exception messages #351

Closed rennerocha closed 2 years ago

rennerocha commented 2 years ago

Improve messages making clear which setting should be defined to configure the failing action. This will help the users of the extension to easily identify how to configure the mandatory settings.

codecov[bot] commented 2 years ago

Codecov Report

Merging #351 (619ed05) into master (f412f21) will decrease coverage by 0.02%. The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   74.05%   74.03%   -0.03%     
==========================================
  Files          72       72              
  Lines        3095     3096       +1     
  Branches      483      483              
==========================================
  Hits         2292     2292              
- Misses        736      737       +1     
  Partials       67       67              
Impacted Files Coverage Δ
spidermon/contrib/actions/email/__init__.py 67.39% <0.00%> (-0.75%) :arrow_down:
spidermon/contrib/actions/email/ses.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/__init__.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/files.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/reports/s3.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/sentry/__init__.py 0.00% <0.00%> (ø)
spidermon/contrib/actions/slack/__init__.py 56.63% <0.00%> (ø)
spidermon/contrib/actions/discord/__init__.py 76.19% <100.00%> (ø)
spidermon/contrib/actions/telegram/__init__.py 88.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f412f21...619ed05. Read the comment docs.