Closed further-reading closed 1 year ago
Base: 74.28% // Head: 74.62% // Increases project coverage by +0.34%
:tada:
Coverage data is based on head (
454eefc
) compared to base (5020fca
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
hey! Would it be possible to add tests for it?
It's still a work in progress haha, of course there'll be tests. We can hold off on the reviews until its ready.
Looks good to me.
I would however add
itemadapter
as a dependency now. Things will work either way because of the dependency with Scrapy, but it makes things more future-proof (e.g. in the unlikely case that Scrapy drops itemadapter as a dependency).
@further-reading Could you please fix the missing dependency in setup.py ?
@further-reading Unless you plan on further changes, e.g. https://github.com/scrapinghub/spidermon/pull/358#discussion_r968693785, we can merge as far as I am concerned.
@Gallaecio apologies I missed that one. Should be sorted out now
Thank you!
https://github.com/scrapinghub/spidermon/issues/353