search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
526 stars 94 forks source link

Change Ubuntu version on workflow settings. #373

Closed mrwbarg closed 1 year ago

mrwbarg commented 1 year ago

Our pipeline hasn't been running for Python 3.6. This is due to an issue with github actions (https://github.com/actions/setup-python/issues/544). Fixing the ubuntu version to 20.04 should fix the problem according to the comments.

codecov[bot] commented 1 year ago

Codecov Report

Base: 74.62% // Head: 74.62% // No change to project coverage :thumbsup:

Coverage data is based on head (9f61527) compared to base (d2ad2cd). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #373 +/- ## ======================================= Coverage 74.62% 74.62% ======================================= Files 73 73 Lines 3113 3113 Branches 366 366 ======================================= Hits 2323 2323 Misses 725 725 Partials 65 65 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

curita commented 1 year ago

@Gallaecio @rennerocha could you check these changes when you have the time? The CI checks don't pass for that version of python otherwise and affect all recent PRs.