Closed mrwbarg closed 1 year ago
Base: 74.89% // Head: 74.98% // Increases project coverage by +0.08%
:tada:
Coverage data is based on head (
32d90b8
) compared to base (062bb7d
). Patch coverage: 100.00% of modified lines in pull request are covered.:exclamation: Current head 32d90b8 differs from pull request most recent head bb03d31. Consider uploading reports for the commit bb03d31 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
It took me a bit to understand why each calculation is needed inside the monitor, maybe some comments explaining why would help
Done
Closes #376
Added option to set thresholds as a percentage of total spider requests' for the
UnwantedHTTPCodesMonitor
. The implementation follows the discussions on the issue and alos @curita's suggestions.Added relevant unit tests.