scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
526 stars 94 forks source link

Replace tox pep8 with pre-commits rules and pipeline #387

Closed VMRuiz closed 1 year ago

VMRuiz commented 1 year ago

Fix https://github.com/scrapinghub/spidermon/issues/385

codecov[bot] commented 1 year ago

Codecov Report

Base: 74.98% // Head: 75.93% // Increases project coverage by +0.95% :tada:

Coverage data is based on head (7766fad) compared to base (32d90b8). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #387 +/- ## ========================================== + Coverage 74.98% 75.93% +0.95% ========================================== Files 73 73 Lines 3174 3179 +5 Branches 375 376 +1 ========================================== + Hits 2380 2414 +34 + Misses 727 695 -32 - Partials 67 70 +3 ``` | [Impacted Files](https://codecov.io/gh/scrapinghub/spidermon/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub) | Coverage Δ | | |---|---|---| | [spidermon/contrib/actions/sentry/\_\_init\_\_.py](https://codecov.io/gh/scrapinghub/spidermon/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL2NvbnRyaWIvYWN0aW9ucy9zZW50cnkvX19pbml0X18ucHk=) | `0.00% <ø> (ø)` | | | [spidermon/contrib/monitors/mixins/validation.py](https://codecov.io/gh/scrapinghub/spidermon/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL2NvbnRyaWIvbW9uaXRvcnMvbWl4aW5zL3ZhbGlkYXRpb24ucHk=) | `91.01% <ø> (ø)` | | | [spidermon/contrib/scrapy/monitors.py](https://codecov.io/gh/scrapinghub/spidermon/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL2NvbnRyaWIvc2NyYXB5L21vbml0b3JzLnB5) | `96.88% <ø> (ø)` | | | [spidermon/contrib/validation/translator.py](https://codecov.io/gh/scrapinghub/spidermon/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL2NvbnRyaWIvdmFsaWRhdGlvbi90cmFuc2xhdG9yLnB5) | `100.00% <ø> (ø)` | | | [spidermon/python/interpreter.py](https://codecov.io/gh/scrapinghub/spidermon/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL3B5dGhvbi9pbnRlcnByZXRlci5weQ==) | `93.33% <ø> (ø)` | | | [spidermon/results/text.py](https://codecov.io/gh/scrapinghub/spidermon/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL3Jlc3VsdHMvdGV4dC5weQ==) | `40.35% <ø> (ø)` | | | [spidermon/contrib/actions/email/ses.py](https://codecov.io/gh/scrapinghub/spidermon/pull/387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL2NvbnRyaWIvYWN0aW9ucy9lbWFpbC9zZXMucHk=) | `85.00% <100.00%> (+85.00%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

VMRuiz commented 1 year ago

Hello @curita , @rennerocha

I have update the PR to replace the tox pep8 black format validation with pre-commit and pre-commit validation in the pipelines.

As future work we can add additional pre-commit checks like isort, flake8, ruff or others