search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
526 stars 94 forks source link

Change supported versions #398

Closed mrwbarg closed 1 year ago

mrwbarg commented 1 year ago

Closes #394.

Updating supported python versions.

mrwbarg commented 1 year ago

Seems like tests were failing because in Python 3.11 re.compile('[0-9]++') is valid (which is not true). I added a bypass for now and opened an issue: https://github.com/python/cpython/issues/105121

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2c487b7) 76.37% compared to head (3354c7c) 76.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #398 +/- ## ======================================== Coverage 76.37% 76.37% ======================================== Files 73 73 Lines 3103 3103 Branches 365 518 +153 ======================================== Hits 2370 2370 Misses 663 663 Partials 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

curita commented 1 year ago

@mrwbarg I think now "++" is a valid regex, looking at the updated re docs: https://docs.python.org/3/library/re.html. It was introduced in 3.11. But changing that test case to any other invalid regex should do it, which you already covered 👍