search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
530 stars 96 forks source link

Refactor spidermon.utils.zyte.Client to use crawler settings #411

Closed VMRuiz closed 1 year ago

VMRuiz commented 1 year ago

Fixes https://github.com/scrapinghub/spidermon/issues/410

VMRuiz commented 1 year ago

I still need to test it to make sure it works properly

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (aa76291) 78.51% compared to head (97bb2f7) 78.52%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #411 +/- ## ======================================= Coverage 78.51% 78.52% ======================================= Files 73 73 Lines 3151 3152 +1 Branches 528 528 ======================================= + Hits 2474 2475 +1 Misses 600 600 Partials 77 77 ``` | [Files Changed](https://app.codecov.io/gh/scrapinghub/spidermon/pull/411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub) | Coverage Δ | | |---|---|---| | [spidermon/contrib/scrapy/extensions.py](https://app.codecov.io/gh/scrapinghub/spidermon/pull/411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL2NvbnRyaWIvc2NyYXB5L2V4dGVuc2lvbnMucHk=) | `85.71% <100.00%> (+0.13%)` | :arrow_up: | | [spidermon/contrib/scrapy/monitors/monitors.py](https://app.codecov.io/gh/scrapinghub/spidermon/pull/411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL2NvbnRyaWIvc2NyYXB5L21vbml0b3JzL21vbml0b3JzLnB5) | `96.68% <100.00%> (+0.01%)` | :arrow_up: | | [spidermon/utils/zyte.py](https://app.codecov.io/gh/scrapinghub/spidermon/pull/411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL3V0aWxzL3p5dGUucHk=) | `91.83% <100.00%> (-0.17%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

VMRuiz commented 1 year ago

Tests with unit tests and SC real jobs, it works as expected