scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
524 stars 94 forks source link

Fix ItemValidationPipeline using __setitem__ without ItemAdapter #415

Closed VMRuiz closed 10 months ago

VMRuiz commented 10 months ago

I don't think we need to conver to dict here and here but I'm keeping the same logic for now

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.40% :tada:

Comparison is base (e070dd8) 78.64% compared to head (be24262) 79.05%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #415 +/- ## ========================================== + Coverage 78.64% 79.05% +0.40% ========================================== Files 73 73 Lines 3152 3151 -1 Branches 528 528 ========================================== + Hits 2479 2491 +12 + Misses 598 590 -8 + Partials 75 70 -5 ``` | [Files Changed](https://app.codecov.io/gh/scrapinghub/spidermon/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub) | Coverage Δ | | |---|---|---| | [spidermon/contrib/scrapy/pipelines.py](https://app.codecov.io/gh/scrapinghub/spidermon/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-c3BpZGVybW9uL2NvbnRyaWIvc2NyYXB5L3BpcGVsaW5lcy5weQ==) | `97.72% <100.00%> (+13.45%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/scrapinghub/spidermon/pull/415/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.