search

scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
524 stars 94 forks source link

Adds limit for nested dict stats computation #421

Closed mrwbarg closed 4 months ago

mrwbarg commented 9 months ago

Closes #416 Adds a setting to limit how deep the coverage is computed for nested dicts.

curita commented 7 months ago

The CI issues have been fixed 🙏 Could you rebase/merge the latest changes from master? @mrwbarg

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (377c4ab) 79.39% compared to head (1281600) 79.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #421 +/- ## ========================================== + Coverage 79.39% 79.42% +0.03% ========================================== Files 76 76 Lines 3222 3228 +6 Branches 534 536 +2 ========================================== + Hits 2558 2564 +6 Misses 593 593 Partials 71 71 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

curita commented 6 months ago

@Gallaecio @rennerocha could you check on this PR? It's ready to be reviewed.

VMRuiz commented 4 months ago

Can we close this in favor of https://github.com/scrapinghub/spidermon/pull/433 ?