Closed further-reading closed 2 months ago
Tests fail because they expect self.crawler.stats
which is None, I assume it's because of the Scrapy 2.11 change to the crawler initialization. One way to work around this in tests is to assign MemoryStatsCollector(crawler)
to it manually if it's None (if tests don't expect any other components of the Crawler instance to be initialized), like in https://github.com/scrapinghub/scrapy-poet/pull/165
The CI issues have been fixed 🙏 Could you rebase/merge the latest changes from master
? @further-reading
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.42%. Comparing base (
ab611d6
) to head (908e4ae
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The CI issues have been fixed 🙏 Could you rebase/merge the latest changes from
master
? @further-reading
@curita Done now, but we have a codecov error as it wants me to add unit tests. I won't have the bandwidth to add these soon I'm afraid.
I'm not sure but I think the test isn't related to the code being tested? I assume it increased the coverage for some of the added lines but not because it tests the added code.
Closes #423 Error handling adds timezone if needed.