scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
524 stars 94 forks source link

fix: (423-fix_time_zone) - making timezone aware if needed #424

Closed further-reading closed 2 months ago

further-reading commented 9 months ago

Closes #423 Error handling adds timezone if needed.

wRAR commented 9 months ago

Tests fail because they expect self.crawler.stats which is None, I assume it's because of the Scrapy 2.11 change to the crawler initialization. One way to work around this in tests is to assign MemoryStatsCollector(crawler) to it manually if it's None (if tests don't expect any other components of the Crawler instance to be initialized), like in https://github.com/scrapinghub/scrapy-poet/pull/165

curita commented 7 months ago

The CI issues have been fixed 🙏 Could you rebase/merge the latest changes from master? @further-reading

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.42%. Comparing base (ab611d6) to head (908e4ae).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #424 +/- ## ========================================== + Coverage 79.39% 79.42% +0.02% ========================================== Files 76 76 Lines 3223 3227 +4 Branches 534 534 ========================================== + Hits 2559 2563 +4 Misses 593 593 Partials 71 71 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

further-reading commented 7 months ago

The CI issues have been fixed 🙏 Could you rebase/merge the latest changes from master? @further-reading

@curita Done now, but we have a codecov error as it wants me to add unit tests. I won't have the bandwidth to add these soon I'm afraid.

wRAR commented 4 months ago

I'm not sure but I think the test isn't related to the code being tested? I assume it increased the coverage for some of the added lines but not because it tests the added code.

VMRuiz commented 2 months ago

Fixed at https://github.com/scrapinghub/spidermon/pull/439