scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
524 stars 94 forks source link

Fix Field names containing '_items' crash field coverage #437

Closed VMRuiz closed 4 months ago

VMRuiz commented 4 months ago

Fixes https://github.com/scrapinghub/spidermon/issues/428

It only cover the case where the fields ends with "_items" but is prefixed with something else like "count_items". Using only _items as field name is still not compatible with the coverage count. We may be able to make it work but it would require a significant rewrite of calculate_field_coverage

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.43%. Comparing base (6b3503b) to head (957104a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #437 +/- ## ======================================= Coverage 79.43% 79.43% ======================================= Files 76 76 Lines 3229 3229 Branches 536 536 ======================================= Hits 2565 2565 Misses 593 593 Partials 71 71 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.