scrapinghub / spidermon

Scrapy Extension for monitoring spiders execution.
https://spidermon.readthedocs.io
BSD 3-Clause "New" or "Revised" License
524 stars 94 forks source link

[434] Allow to filter jobs in ZyteJobsComparisonMonitor by close_reason #440

Open shafiq-muhammad opened 3 months ago

shafiq-muhammad commented 3 months ago

Adds limit for nested dict stats computation

Added a new setting SPIDERMON_JOBS_COMPARISON_CLOSE_REASONS to allow ZyteJobsComparisonMonitor to filter by the ScrapyCloud jobs with their close_reason stat.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.54%. Comparing base (6ea9f67) to head (0ebe5f9). Report is 2 commits behind head on master.

:exclamation: Current head 0ebe5f9 differs from pull request most recent head 868566f

Please upload reports for the commit 868566f to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #440 +/- ## ========================================== + Coverage 79.51% 79.54% +0.03% ========================================== Files 76 76 Lines 3237 3242 +5 Branches 537 539 +2 ========================================== + Hits 2574 2579 +5 Misses 593 593 Partials 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aaneto commented 2 months ago

Just a quick FYI @shafiq-muhammad @curita, I believe the pipeline is failing due to a regression from pytest 8.1.1 to 8.2.0.

My validation was:

Hope this helps (and is correct regardless of environment).

VMRuiz commented 2 months ago

Yes, it looks like Pytest 8.2.0 release has caused a lot of troubles according to their issues page. @shafiq-muhammad , Could you please pin pytest to 8.1.1 until they release a new version?