search

scrapinghub / splash

Lightweight, scriptable browser as a service with an HTTP API
BSD 3-Clause "New" or "Revised" License
4.04k stars 508 forks source link

Update download-qt-installer.sh #1103

Closed rplati closed 3 years ago

rplati commented 3 years ago

fixed QT download link

Fixes #1100

codecov[bot] commented 3 years ago

Codecov Report

Merging #1103 (22cdbcd) into master (75a5394) will increase coverage by 48.13%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1103       +/-   ##
===========================================
+ Coverage        0   48.13%   +48.13%     
===========================================
  Files           0       55       +55     
  Lines           0     6183     +6183     
  Branches        0      849      +849     
===========================================
+ Hits            0     2976     +2976     
- Misses          0     3060     +3060     
- Partials        0      147      +147
Impacted Files Coverage Δ
splash/jsutils.py 72.72% <0.00%> (ø)
splash/har/__init__.py 100.00% <0.00%> (ø)
splash/browser_tab.py 65.87% <0.00%> (ø)
splash/kernel/lua_parser.py 95.36% <0.00%> (ø)
splash/errors.py 100.00% <0.00%> (ø)
splash/__init__.py 100.00% <0.00%> (ø)
splash/lua_runner.py 68.96% <0.00%> (ø)
splash/qtutils.py 50.60% <0.00%> (ø)
splash/lua_runtime.py 72.28% <0.00%> (ø)
splash/kernel/kernel.py 33.33% <0.00%> (ø)
... and 45 more
rplati commented 3 years ago

Are you in the habit of linking a pull request to an issue? I can’t seem to do that. Or do I just close #1100?

Gallaecio commented 3 years ago

Are you in the habit of linking a pull request to an issue? I can’t seem to do that.

Done :slightly_smiling_face:

It can be done in the pull request description.

Gallaecio commented 3 years ago

Let’s wait for a second maintainer to have a chance to review it. We usually try to get approval from 2 maintainers before we merge changes. cc @kmike

kmike commented 3 years ago

Thanks @rplati and @Gallaecio !