scrapinghub / splash

Lightweight, scriptable browser as a service with an HTTP API
BSD 3-Clause "New" or "Revised" License
4.08k stars 514 forks source link

Add Github Actions #1141

Closed Laerte closed 2 years ago

Laerte commented 2 years ago

I pinned the setuptools version to 57.5.0, because 58.0.0 have a breaking change:

That make funcparserlib dependency not work because it use use_2to3.

Changed the CIRCLE_CI env to CI that is the variable that Github Actions use.

Used a dirty hack in order to make TTY work. Explanation here

For some unknown reason i could not make it Codecov work in my tests.

I also have the action to publish image to docker repository but i not add to this PR (But i can if is needed).

Gallaecio commented 2 years ago

I think the codecov issue is because .git does not get included into the image. Maybe it can be mounted as a Docker volume? Or maybe the whole source should be mounted as a volume, and codecov be called from outside the Docker image, as a GitHub Actions step.

Laerte commented 2 years ago

@Gallaecio Yeah, I indeed passed the .git folder via volume arg but i get the error

Error: Could not determine repo and owner

But the flow itself its working.

wRAR commented 2 years ago

Thank you!