Tracking bodies of specific requests.

scrapinghub / splash

Lightweight, scriptable browser as a service with an HTTP API

BSD 3-Clause "New" or "Revised" License

4.09k stars 513 forks source link

Tracking bodies of specific requests. #880

Open starrify opened 5 years ago

starrify commented 5 years ago

Let's talk about visibility of request/response bodies in HAR as generated by splash:har:

For response bodies, globally: there is splash.response_body_enabled
For response bodies, per response: there is request:enable_response_body
For request bodies, globally: there is splash.request_body_enabled
For request bodies, per request: N/A for now (current version: 691a8ab).

Therefor I guess that it may be beneficial to introduce something like request:enable_request_body to have bodies of this specific requests included in the generated HAR.

kmike commented 5 years ago

@starrify this sounds good; pull requests are welcome! Do you have a specific use case for this feature?

starrify commented 5 years ago

My use case is when I want to retrieve body of only some specific requests. :) I'm currently using splash.request_body_enabled but feel somehow reluctant as this would unnecessarily affect unrelated requests and increase the overhead.

JavierRuano commented 5 years ago

With that software it is usual one misuse case :-)

El mar., 26 feb. 2019 0:28, Peng-Yu Chen notifications@github.com escribió:

My use case is when I want to retrieve body of only some specific requests. :) I'm currently using splash.request_body_enabled but feel somehow reluctant as this would unnecessarily affect unrelated requests and increase the overhead.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scrapinghub/splash/issues/880#issuecomment-467226867, or mute the thread https://github.com/notifications/unsubscribe-auth/Agwyu8bcrmTXs5ckxYUf5T_8gj-LAJWEks5vRHGUgaJpZM4bJuqb .