search

scrapinghub / web-poet

Web scraping Page Objects core library
https://web-poet.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
95 stars 15 forks source link

jmespath shortcut #167

Closed kmike closed 1 year ago

kmike commented 1 year ago

I opted in for a runtime check to simplify the implementation a bit. We can drop it after bumping min parsel version requirement.

Gallaecio commented 1 year ago

I wonder if we should use a try-except here instead, even if it won’t make much of a difference.

codecov[bot] commented 1 year ago

Codecov Report

Merging #167 (097e072) into master (062493f) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 097e072 differs from pull request most recent head eb7de9f. Consider uploading reports for the commit eb7de9f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #167 +/- ## ======================================= Coverage 98.59% 98.59% ======================================= Files 28 28 Lines 1281 1285 +4 ======================================= + Hits 1263 1267 +4 Misses 18 18 ``` | [Impacted Files](https://codecov.io/gh/scrapinghub/web-poet/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub) | Coverage Δ | | |---|---|---| | [web\_poet/mixins.py](https://codecov.io/gh/scrapinghub/web-poet/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapinghub#diff-d2ViX3BvZXQvbWl4aW5zLnB5) | `100.00% <100.00%> (ø)` | |