Closed Gallaecio closed 1 year ago
Merging #169 (2e9a9c0) into master (bfd6683) will increase coverage by
0.00%
. The diff coverage isn/a
.
Not sure if completely removing docs is a good idea in general but I've found the old version of the page to be very complicated, especially for someone who is not familiar with scrapy-poet (when reading it back then) yet so trimming it down is welcome.
Hey @Gallaecio! These docs look much better than before, so I'm merging it. I still think though that we should improve the introduction: the "output class" thing doesn't look clear to me, but I don't have a concrete suggestion.
My goal was to greatly simplify https://web-poet.readthedocs.io/en/stable/page-objects/rules.html.
However, I wonder if I went too far; the new pages are ~25% of the old page in terms of line count.
I removed much of the content, and although I aimed to keep the core information around, I did not always do that. For example, the entire last section is gone without its information making it in any form into the new page; I wonder if we should keep some of that information.
I recommend reading the old page, then the new pages, and see how you feel about the missing information.