Added support for more interface types in IOSXR

scrapli / scrapli_cfg

Network device Configuration Management with scrapli

https://scrapli.github.io/scrapli_cfg/

MIT License

32 stars 4 forks source link

Added support for more interface types in IOSXR #19

Closed m1009d closed 3 years ago

m1009d commented 3 years ago

The current regexp for ETHERNET_INTERFACES in the cisco_iosxr/patterns.py file will not catch TenGigE or HundredGigE interfaces. Please see my proposed simple change in the regexp.

carlmontanari commented 3 years ago

Hey @m1009d thanks for opening this!

Could you update to include just ethernet -- this is for xrv9k stuff (maybe elsewhere too?), and run make lint to have black do its thing.

Thanks!

Carl

m1009d commented 3 years ago

Hi @carlmontanari , I've added the ethernet interface type and pushed the change but I have no experience with make lint and I don't know exactly how should I use it.

carlmontanari commented 3 years ago

Nice! Thanks for the update!

Sorry about that -- make is used for some "shortcut" type stuff in this case. lint is a directive that runs black and other formatters/linters -- you can see that here.

TL;DR to get build passing is you just need to run python -m black . like the makefile does -- black will auto format the code and then should be good to go! HTH!

Carl

carlmontanari commented 3 years ago

Boom, LGTM, thank you much @m1009d