search

scrapli / scrapligo

scrapli, but in go!
MIT License
244 stars 35 forks source link

Exposing NETCONF server capabilities #140

Closed karimra closed 11 months ago

karimra commented 11 months ago

Hi,

I'm trying to write a netconf client using the scraligo driver. Looked through the code and it seems like the server capabilities are not exposed, there is a ServerHasCapability(s string) bool function which requires prior knowledge of the possible capabilities a server might support. It would be useful to have a ServerCapabilities() []string function that returns a copy of d.serverCapabilities. If this is ok with you I can create a PR adding that function.

carlmontanari commented 11 months ago

Ah! Yeah sounds great! I heard a whisper about the new project :) would love to get involved too if there’s anything I can do or any changes I can make here to help things along! Maybe we can chat on discord or whatever too if that’s easier!

karimra commented 11 months ago

Thanks, yes happy to discuss I could use someone with more NETCONF knowledge.

carlmontanari commented 11 months ago

merged, thanks a bunch!