search

scrapli / scrapligo

scrapli, but in go!
MIT License
258 stars 42 forks source link

Fixes #155 - add WithStandardTransportDialTimeout #156

Closed patrickfnielsen closed 1 year ago

patrickfnielsen commented 1 year ago

As we talked about, here is an PR to add support for dial timeout using the standard transport. Let me know if there's anything you want changed :)

patrickfnielsen commented 1 year ago

Ah sorry I looked a bit but did not see it also applied to the others. I have renamed it as requested, and changed the docstring to your suggestion.

carlmontanari commented 1 year ago

No worries, sorry I didnt call that out earlier -- it (this TimeoutSocket bit) was basically forgotten about in scrapligo it seems :D

just pushed a minor fix for appeasing a linter and once ci is done will get this merged. probably will cut a release too since I had some other big stuff recently and never got around to that. thanks again for the great work @patrickfnielsen !