netixx
commented
3 months ago Here is the bit of code I am using to call the driver:
// query makes sure we don't do multiple simultaneous queries to the same host.
func (p *NetconfProxy) query(q Query) (string, error) {
conn, err := p.driverFactory(q.hostname)
if err != nil {
return "", fmt.Errorf("error during netconf connection to %s: %w", q.hostname, err)
}
if err := conn.Open(); err != nil {
return "", fmt.Errorf("cannot open connection to %s: %w", q.hostname, err)
}
defer conn.Close()
if !conn.Transport.IsAlive() {
return "", fmt.Errorf("transport is dead after driver creation for %s", q.hostname)
}
var result *response.NetconfResponse
switch q.queryType {
case NetconfQueryTypeGet:
result, err = conn.Get(q.query)
case NetconfQueryTypeGetConfig:
// config is long, increase timeout
result, err = conn.GetConfig(q.query)
case NetconfQueryTypeRPC:
result, err = conn.RPC(opoptions.WithFilter(q.query))
default:
return "", fmt.Errorf("unknown query type %s", q.queryType)
}
if err != nil {
return "", fmt.Errorf("error during netconf query call: %w", err)
}
if result.Failed != nil {
return result.Result, fmt.Errorf("error during netconf query: %w", result.Failed)
}
return result.Result, nil
}
// driverFactory returns an opened netconf driver connection, ready to be queried.
func (p *NetconfProxy) driverFactory(hostname string) (*netconf.Driver, error) {
// f, _ := os.Create("scrapli.log")
logger, _ := logging.NewInstance(
logging.WithLevel(logging.Critical),
logging.WithLogger(p.log.Warn),
)
opts := []util.Option{
// reduce CPU usage because of polling loop
options.WithReadDelay(10 * time.Millisecond),
options.WithPort(22),
options.WithAuthNoStrictKey(),
options.WithAuthUsername(p.bastionUsername),
options.WithAuthPrivateKey(p.bastionPrivateKeyPath, ""),
options.WithTransportType("system"),
options.WithSystemTransportOpenArgs([]string{
"-t", "--", "-P",
hostname,
"--netconf", "-p", "830",
}),
options.WithLogger(logger),
options.WithTimeoutOps(120 * time.Second),
// options.WithChannelLog(f),
}
// juniper has a bug which make it mandatory to use self closing tags
// see https://github.com/scrapli/scrapligo/issues/73 for details
if strings.HasSuffix(hostname, "-ptx") {
opts = append(
opts,
options.WithNetconfForceSelfClosingTags(),
)
}
return netconf.NewDriver(
p.bastionFQDN,
opts...,
// options.WithChannelLog(f),
// options.WithLogger(logger),
)
}Note that I always call conn.Close(), the only case where I don't do it is when conn.Open() fails, but that seemed ok when I tested it.
carlmontanari
hellt
Hello,
I am running a REST API that runs netconf in the backend.
I am investigating an issue where my app does not release a big chunk of it's memory.
I used profiling to identify what is holding the memory, and I got the following:
It seems that the
readfunction is holding a lot of memory, event though there are no more queries being processed. I am not sure why it doesn't get cleaned up by the garbage collector though. Profiling suggests that it's somewhere around here: https://github.com/scrapli/scrapligo/blob/ed0178113d9d227f9cef86dc42001f4f2da48d4c/channel/read.go#L43.My first guess is that after
c.Q.Enqueue(b)bshould be wiped ?Do you have any idea why ? Would you have some time to troubleshoot together ?