scrapli / scrapligo

scrapli, but in go!
MIT License
258 stars 42 forks source link

Add Option to Exclude XML Header for NETCONF Messages #195

Closed mtuska closed 1 month ago

mtuska commented 1 month ago

Title:

Add Option to Exclude XML Header for NETCONF Messages

Description:

This pull request introduces an option to exclude the XML header from NETCONF messages. The motivation behind this change stems from an issue encountered with certain devices, such as Calix's earlier platforms, where the inclusion of the XML header causes the system to misinterpret the message as an invalid XML document. This update provides flexibility by allowing users to disable the header when necessary.

Changes:

Reason for Change:

The addition of the ExcludeHeader flag resolves issues with NETCONF messages being rejected by certain devices that expect raw XML content without the standard XML declaration header.

Impact:

carlmontanari commented 1 month ago

👋 hey @mtuska -- thanks for the detailed info and funny commit message :) -- LGTM!