search

scrapper / postrunner

Application to manage FIT files such as those produced by Garmin fitness devices
GNU General Public License v2.0
62 stars 14 forks source link

add support for converting celsius to fahrenheit #36

Closed masneyb closed 1 year ago

masneyb commented 1 year ago

use the newly introduced function convert_value() in fit4ruby to convert celsius to fahrenheit

masneyb commented 1 year ago

This patch depends on this change to fit4ruby: https://github.com/scrapper/fit4ruby/pull/26

masneyb commented 1 year ago

@scrapper : I rebased my code against your latest main branch and updated my branch to use your new conversion_offset(). CI is failing due to the following error:

 undefined method `conversion_offset' for #<PostRunner::ActivityListView:0x0000563465c61548>

I suspect the issue is that you will need to publish a new version of fit4ruby with the latest code.

scrapper commented 1 year ago

I've released a new version of fit4ruby (3.11.0). This should fix the above error. If so, please re-open the pull request and I'm happy to merge it.

masneyb commented 1 year ago

@scrapper : I rebased my MR and everything looks good now.