search

scrapy-plugins / scrapy-jsonschema

Scrapy schema validation pipeline and Item builder using JSON Schema
BSD 3-Clause "New" or "Revised" License
44 stars 12 forks source link

Drop Python2 support in order to fix failing tests due to item metaclass updates in scrapy>=2.2.0 #19

Closed BurnzZ closed 4 years ago

BurnzZ commented 4 years ago

Fixes #18

Disclaimer:

This doesn't address the new deprecation warnings from Scrapy's new version since a fix could make it backwards incompatible:

/Users/burnzz/dev/scrapinghub/scrapy-jsonschema/tests/test_item.py:228: ScrapyDeprecationWarning: scrapy.item.DictItem is deprecated, please use scrapy.item.Item instead
    item = PatternPropertiesItem()
BurnzZ commented 4 years ago

The tox tests for Python 2.7 has failed because in Scrapy==2.2.0, Python2 support has completely been dropped: https://docs.scrapy.org/en/latest/news.html#scrapy-2-2-0-2020-06-24

codecov[bot] commented 4 years ago

Codecov Report

Merging #19 into master will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   97.93%   98.00%   +0.06%     
==========================================
  Files           3        3              
  Lines          97      100       +3     
  Branches       22       22              
==========================================
+ Hits           95       98       +3     
  Misses          1        1              
  Partials        1        1
Impacted Files Coverage Δ
scrapy_jsonschema/item.py 98.48% <100.00%> (+0.04%) :arrow_up:
scrapy_jsonschema/pipeline.py 96.66% <0.00%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43dc70d...f1c6d50. Read the comment docs.

JakeCowton commented 4 years ago

Used this PR extensively over the past few days. Looks great!

VMRuiz commented 4 years ago

Merged! Thanks for your collaboration!