Gallaecio commented 3 years ago

Based on this, switching from xenial to something newer (the default image?) may do the trick. I’ll give it a try myself in a separate pull request.

Gallaecio commented 3 years ago

It worked.

codecov[bot] commented 3 years ago

Codecov Report

Merging #27 (9bfe3ac) into master (8b29c89) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files           4        4           
  Lines         106      106           
  Branches       22       22           
=======================================
  Hits          102      102           
  Misses          3        3           
  Partials        1        1

Impacted Files	Coverage Δ
scrapy_jsonschema/item.py	`95.65% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b29c89...9bfe3ac. Read the comment docs.

elacuesta commented 3 years ago

Rebased and squashed for simplicity

scrapy-plugins / scrapy-jsonschema

Update string literal comparison #27

Codecov Report