scrapy-plugins / scrapy-playwright

🎭 Playwright integration for Scrapy
BSD 3-Clause "New" or "Revised" License
992 stars 108 forks source link

Test refactoring #223

Closed elacuesta closed 1 year ago

elacuesta commented 1 year ago
  1. Updated tests to use the most recent versions of pytest plugins (previously not working with pytest-asyncio>=0.11)
  2. Split asyncio/twisted tests, they don't play well together
  3. Bump minimum Python version to 3.8, to use unittest.IsolatedAsyncioTestCase (py37 is EOL anyway)
  4. Pinned playwright==1.36.0 in tests, playwright==1.37.0 fails for some reason
codecov[bot] commented 1 year ago

Codecov Report

Merging #223 (f280f4f) into main (1c3f425) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #223   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          388       388           
=========================================
  Hits           388       388           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more