search

scrapy-plugins / scrapy-playwright

🎭 Playwright integration for Scrapy
BSD 3-Clause "New" or "Revised" License
911 stars 101 forks source link

Supporting for windows #251

Closed sanzenwin closed 1 week ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (5b254e4) 100.00% compared to head (cc4c4ac) 95.77%. Report is 2 commits behind head on main.

:exclamation: Current head cc4c4ac differs from pull request most recent head a6b9f6e. Consider uploading reports for the commit a6b9f6e to get more accurate results

Files Patch % Lines
scrapy_playwright/handler.py 31.03% 20 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #251 +/- ## =========================================== - Coverage 100.00% 95.77% -4.23% =========================================== Files 5 5 Lines 448 473 +25 =========================================== + Hits 448 453 +5 - Misses 0 20 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ProfoundWanderer commented 3 months ago

Is this pull request still actively being worked on? @sanzenwin @elacuesta

elacuesta commented 3 months ago

I personally am not working on this at the moment. I left a few comments/suggestions/questions in this PR. I will try to find some time to work on this in the near future, but I can't make any promises. The best way of using this package on Windows is still under WSL.

ProfoundWanderer commented 3 months ago

I personally am not working on this at the moment. I left a few comments/suggestions/questions in this PR. I will try to find some time to work on this in the near future, but I can't make any promises.

The best way of using this package on Windows is still under WSL.

I don't mind trying to work on it, I just didn't want to step on any toes. Personally, didn't want to go through WSL hoops if it was possible to get this supported on Windows at all.