search

scrapy-plugins / scrapy-zyte-api

Zyte API integration for Scrapy
BSD 3-Clause "New" or "Revised" License
36 stars 19 forks source link

Add LocationSessionConfig with docstrings #215

Closed VMRuiz closed 2 months ago

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.69%. Comparing base (a1d81d1) to head (5e771e0). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #215 +/- ## ========================================== + Coverage 97.67% 97.69% +0.01% ========================================== Files 14 14 Lines 1551 1564 +13 Branches 328 330 +2 ========================================== + Hits 1515 1528 +13 Misses 15 15 Partials 21 21 ``` | [Files with missing lines](https://app.codecov.io/gh/scrapy-plugins/scrapy-zyte-api/pull/215?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy-plugins) | Coverage Δ | | |---|---|---| | [scrapy\_zyte\_api/\_\_init\_\_.py](https://app.codecov.io/gh/scrapy-plugins/scrapy-zyte-api/pull/215?src=pr&el=tree&filepath=scrapy_zyte_api%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy-plugins#diff-c2NyYXB5X3p5dGVfYXBpL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | | | [scrapy\_zyte\_api/\_session.py](https://app.codecov.io/gh/scrapy-plugins/scrapy-zyte-api/pull/215?src=pr&el=tree&filepath=scrapy_zyte_api%2F_session.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scrapy-plugins#diff-c2NyYXB5X3p5dGVfYXBpL19zZXNzaW9uLnB5) | `100.00% <100.00%> (ø)` | |
VMRuiz commented 2 months ago

@Gallaecio Is there anything else required here?

Gallaecio commented 2 months ago

Only a review from someone other than me, as my approval feels like cheating now :)