search

scrapy-plugins / scrapy-zyte-smartproxy

Zyte Smart Proxy Manager (formerly Crawlera) middleware for Scrapy
BSD 3-Clause "New" or "Revised" License
356 stars 88 forks source link

Remove username and password settings since it's been removed from cr… #72

Closed hcoura closed 5 years ago

hcoura commented 5 years ago

…awlera completely

This is backwards incompatible of course

codecov[bot] commented 5 years ago

Codecov Report

Merging #72 into master will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   95.29%   95.23%   -0.06%     
==========================================
  Files           3        3              
  Lines         170      168       -2     
==========================================
- Hits          162      160       -2     
  Misses          8        8
Impacted Files Coverage Δ
scrapy_crawlera/middleware.py 94.9% <100%> (-0.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49e9b8a...0457b61. Read the comment docs.