search

scrapy-plugins / scrapy-zyte-smartproxy

Zyte Smart Proxy Manager (formerly Crawlera) middleware for Scrapy
BSD 3-Clause "New" or "Revised" License
357 stars 88 forks source link

Fix check is crawlera response #89

Closed denisgermano closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #89 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #89   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          228       228           
=========================================
  Hits           228       228
Impacted Files Coverage Δ
scrapy_crawlera/middleware.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c57c95...4d6acf4. Read the comment docs.

eLRuLL commented 4 years ago

very nice work, just a question here, is Crawlera deprecating the X-Crawlera-Version header? If so, could you please point that out here and add it to the documentation?

This should definitely be added as a new version as well, so we are missing the bump.

denisgermano commented 4 years ago

Hey @eLRuLL It is not being deprecated, the latest release has a bug that is returning an empty value for the X-Crawlera-Version header