search

scrapy / cssselect

CSS Selectors for Python
https://cssselect.readthedocs.io/
Other
291 stars 61 forks source link

Add tests for xpath_pseudo_element #100

Closed Gallaecio closed 1 year ago

redapple commented 4 years ago

parsel has xpath_attr_functional_pseudo_element which calls function.argument_types(). I haven't tested if this removal affects it See https://github.com/scrapy/parsel/blob/bcfa589e5f15b8f4230a699a0d64a3205732a317/parsel/csstranslator.py#L85

codecov[bot] commented 4 years ago

Codecov Report

Merging #100 (9ba91e9) into master (48bbfb1) will increase coverage by 0.11%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   96.04%   96.15%   +0.11%     
==========================================
  Files           2        2              
  Lines         884      884              
  Branches      176      176              
==========================================
+ Hits          849      850       +1     
+ Misses         19       18       -1     
  Partials       16       16
Impacted Files Coverage Δ
cssselect/parser.py 97.07% <0.00%> (+0.18%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Gallaecio commented 4 years ago

Thanks, I had no idea of the implications. Switched my approach from removing the code to adding tests for it.