search

scrapy / cssselect

CSS Selectors for Python
https://cssselect.readthedocs.io/
Other
291 stars 61 forks source link

Add suppport for `[of S]`? part in nth-child's arguments #120

Open annbgn opened 3 years ago

annbgn commented 3 years ago

Closes #76.

annbgn commented 3 years ago

i know the tests will be failing, but since i promised to have an update today, here it is :)

codecov[bot] commented 3 years ago

Codecov Report

Merging #120 (44aeedd) into master (f1fcf2b) will decrease coverage by 0.54%. The diff coverage is 96.18%.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   96.12%   95.58%   -0.55%     
==========================================
  Files           2        2              
  Lines         878      929      +51     
  Branches      153      166      +13     
==========================================
+ Hits          844      888      +44     
- Misses         18       23       +5     
- Partials       16       18       +2
Impacted Files Coverage Δ
cssselect/parser.py 96.10% <94.63%> (-0.96%) :arrow_down:
cssselect/xpath.py 94.67% <98.85%> (+0.07%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

wRAR commented 3 years ago

@annbgn @elacuesta do we still need anything else done here?

annbgn commented 3 years ago

do we still need anything else done here?

imho no i undrafted this pr