Gallaecio commented 4 years ago

In order to avoid using Sybil, I’ve had to:

Turn non-doctest (i.e. without >>>) code blocks into doctest
I had to add >>> at the end of every block of code, because otherwise ``` would be picked up as expected output.

The changes fix 2 issues, a sorting issue and a missing parameter in output.

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          111       188   +77     
=========================================
+ Hits           111       188   +77

Impacted Files	Coverage Δ
itemadapter/utils.py	`100.00% <0.00%> (ø)`
itemadapter/adapter.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53ab587...d114b51. Read the comment docs.

elacuesta commented 3 years ago

@Gallaecio The build fails for py35 because dataclasses is not available, is there a way to omit the check there?

Edit: See the PR below, dropping py35 support will fix the build.

scrapy / itemadapter

Test code from README.md #36

Codecov Report