search

scrapy / itemadapter

Common interface for data container classes
BSD 3-Clause "New" or "Revised" License
61 stars 13 forks source link

Add tests for init=False (dataclass/attrs) #41

Closed elacuesta closed 3 years ago

elacuesta commented 3 years ago

Continuation of #31, closes #30.

codecov[bot] commented 3 years ago

Codecov Report

Merging #41 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          130       130           
=========================================
  Hits           130       130

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7695d2...f7fa0ee. Read the comment docs.

elacuesta commented 3 years ago

@ejulio please take a look at this PR. I've set it to close #30, let me know if you have any objections.

ejulio commented 3 years ago

Sorry for the delay @elacuesta :sweat: Looks good