search

scrapy / itemadapter

Common interface for data container classes
BSD 3-Clause "New" or "Revised" License
61 stars 13 forks source link

Deprecate undocumented predicates from the `utils` module #56

Closed elacuesta closed 2 years ago

elacuesta commented 3 years ago

~To be merged only after #54~ Done

Deprecate is_attrs_instance, is_dataclass_instance, is_pydantic_instance and is_scrapy_item from the utils module. Just to be polite, we are still on 0.x versioning and they are not even documented.

codecov[bot] commented 3 years ago

Codecov Report

Merging #56 (8f75e5a) into master (bb722cf) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 8f75e5a differs from pull request most recent head 34527a1. Consider uploading reports for the commit 34527a1 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          272       266    -6     
=========================================
- Hits           272       266    -6
Impacted Files Coverage Δ
itemadapter/adapter.py 100.00% <100.00%> (ø)
itemadapter/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb722cf...34527a1. Read the comment docs.