get_field_meta error handling

scrapy / itemadapter

Common interface for data container classes

BSD 3-Clause "New" or "Revised" License

62 stars 13 forks source link

get_field_meta error handling #6

Closed kmike closed 4 years ago

kmike commented 4 years ago

Currently get_field_meta raises TypeError for dicts. I think it should be a special TypeError subclass (to allow catching it reliably), or a default value + TypeError subclass (when default is not provided), or just an empty read-only dict (dict fields don't have metadata, after all).

elacuesta commented 4 years ago

Done in 3594f8f52767e499c86182e25509dce893cbf6ae