search

scrapy / itemadapter

Common interface for data container classes
BSD 3-Clause "New" or "Revised" License
61 stars 13 forks source link

Simplify dataclass tests #69

Closed elacuesta closed 1 year ago

elacuesta commented 1 year ago

Follow up of #66: no need to catch import errors when importing things from dataclasses.

codecov[bot] commented 1 year ago

Codecov Report

Merging #69 (a63ec05) into master (0bf9f0c) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head a63ec05 differs from pull request most recent head fd3eb05. Consider uploading reports for the commit fd3eb05 to get more accurate results

@@            Coverage Diff            @@
##            master       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          318       305   -13     
=========================================
- Hits           318       305   -13
Impacted Files Coverage Δ
itemadapter/_imports.py 100.00% <ø> (ø)
itemadapter/adapter.py 100.00% <100.00%> (ø)
itemadapter/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kmike commented 1 year ago

Nice, thanks @elacuesta!