search

scrapy / itemloaders

Library to populate items using XPath and CSS with a convenient API
BSD 3-Clause "New" or "Revised" License
44 stars 16 forks source link

fixed add_xpath with variables #48

Closed peonone closed 3 years ago

peonone commented 3 years ago

I got XPath error: Undefined variable in id($id)/text() for loader.add_xpath("field", "id($id)/text()", id="myid") and this PR fixes it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #48 (6951242) into master (228dd49) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           4        4           
  Lines         255      255           
=======================================
  Hits          254      254           
  Misses          1        1
Impacted Files Coverage Δ
itemloaders/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 228dd49...6951242. Read the comment docs.

Gallaecio commented 3 years ago

Thanks!