search

scrapy / itemloaders

Library to populate items using XPath and CSS with a convenient API
BSD 3-Clause "New" or "Revised" License
44 stars 16 forks source link

test_get_func_args() will fail in Python 3.12.3 #76

Closed wRAR closed 5 months ago

wRAR commented 5 months ago

Looks like https://github.com/python/cpython/issues/86951 has been fixed and so we will need to update the test expectations depending on the version.

wRAR commented 5 months ago

According to e.g. https://github.com/scrapy/scrapy/actions/runs/8676036495/job/23790339325?pr=6309 it looks like this fix also happened in e.g. 3.11.9, so maybe we should either just remove the itemgetter test case or expect one of two results, without checking the Python version?