Fix adding set object to itemloader

scrapy / itemloaders

Library to populate items using XPath and CSS with a convenient API

BSD 3-Clause "New" or "Revised" License

45 stars 16 forks source link

Fix adding set object to itemloader #85

Closed VMRuiz closed 5 months ago

VMRuiz commented 5 months ago

Some test are failing because the list contains the element in a different order, not sure if I should fix the test or the code itself...

Gallaecio commented 5 months ago

The test, I think.

wRAR commented 5 months ago

I wonder why is it failing on 3.9 and 3.10, I don't think anything changed in 3.11 related to collection order? And I checked locally, list({"foo", "bar"}) == ['bar', 'foo'] on all versions that I checked, including 3.11.