search

scrapy / parsel

Parsel lets you extract data from XML/HTML documents using XPath or CSS selectors
BSD 3-Clause "New" or "Revised" License
1.13k stars 144 forks source link

Run black #224

Closed wRAR closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #224 (b86ca1b) into master (dc2eb7d) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head b86ca1b differs from pull request most recent head 6cc1696. Consider uploading reports for the commit 6cc1696 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master      #224   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          291       291           
  Branches        51        51           
=========================================
  Hits           291       291
Impacted Files Coverage Δ
parsel/__init__.py 100.00% <100.00%> (ø)
parsel/csstranslator.py 100.00% <100.00%> (ø)
parsel/selector.py 100.00% <100.00%> (ø)
parsel/utils.py 100.00% <100.00%> (ø)
parsel/xpathfuncs.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc2eb7d...6cc1696. Read the comment docs.

Gallaecio commented 3 years ago

https://github.com/psf/black/issues/315#issuecomment-395457972

wRAR commented 3 years ago

That's a nice set of test failures :)

Gallaecio commented 3 years ago

I’m OK with ignoring too-many-lines from PyLint for now, to avoid unrelated code refactoring in this pull request.

The typing one seems to only require moving a misplaced inline comment at https://github.com/scrapy/parsel/pull/224/files#diff-ebd4bddff4fff1c4c2a388f9b86d0954fd6d518fbce0104d185c685fae3132ebR43-R44 1 line above, assuming Black is OK with that.