search

scrapy / parsel

Parsel lets you extract data from XML/HTML documents using XPath or CSS selectors
BSD 3-Clause "New" or "Revised" License
1.15k stars 146 forks source link

Dropping python 3.6 support #251

Closed Nirzak closed 2 years ago

Nirzak commented 2 years ago

Dropping support for python version 3.6 as its support has reached the end of life.

Nirzak commented 2 years ago

Will close #250

Nirzak commented 2 years ago

The pypy3 test is failing cause by default it's trying to install pypy3.6 (3.6.12) which doesn't meet the condition of version>=3.7. If we need this then we have to mention the condition separately on rerquired_packages parameter.

wRAR commented 2 years ago

For pypy you should be able to specify "pypy3.9" if you update actions/setup-python to v4.

Nirzak commented 2 years ago

For pypy you should be able to specify "pypy3.9" if you update actions/setup-python to v4.

Yeah I know. I was just confirming if I have to strictly mention it or not. Ok I will update the PR

Nirzak commented 2 years ago

Should I also update actions checkout to version 3 and actions setup python to version 4? @wRAR

wRAR commented 2 years ago

I thought you were asking if it's fine to keep 3.6 support for PyPy or something like that? I don't see how is required_packages related to it otherwise.

wRAR commented 2 years ago

Should I also update actions checkout to version 3 and actions setup python to version 4? @wRAR

Yes please.

Nirzak commented 2 years ago

Ok

codecov[bot] commented 2 years ago

Codecov Report

Merging #251 (0c49e80) into master (6451476) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 0c49e80 differs from pull request most recent head 0599a6a. Consider uploading reports for the commit 0599a6a to get more accurate results

@@            Coverage Diff            @@
##            master      #251   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          138       138           
  Branches        33        29    -4     
=========================================
  Hits           138       138

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Nirzak commented 2 years ago

Looks like all the checks are fine now.

Nirzak commented 2 years ago

I thought you were asking if it's fine to keep 3.6 support for PyPy or something like that? I don't see how is required_packages related to it otherwise.

Yeah, I asked if any dependencies are linked to pypy3.6 or not. But as you have confirmed that we can upgrade it to use pypy3.9 so I have done it.

wRAR commented 2 years ago

Thanks!