search

scrapy / parsel

Parsel lets you extract data from XML/HTML documents using XPath or CSS selectors
BSD 3-Clause "New" or "Revised" License
1.11k stars 137 forks source link

Don't use a not needed private cssselect method. #256

Closed wRAR closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #256 (9638be2) into master (f1e4123) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #256   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          138       138           
  Branches        29        29           
=========================================
  Hits           138       138
Impacted Files Coverage Δ
parsel/csstranslator.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

kmike commented 1 year ago

Looks good, thanks @wRAR!

Does it mean that parsel 1.6 won't work with the upcoming csselect release?

Gallaecio commented 1 year ago

Does it mean that parsel 1.6 won't work with the upcoming csselect release?

It does. Would it be OK as long as we release a new parsel before we release a new cssselect? Or, as @wRAR suggested elsewhere, should we consider deprecating those functions instead of removing them from cssselect?

kmike commented 1 year ago

I'm fine with both approaches.