scrapy / parsel

Parsel lets you extract data from XML/HTML documents using XPath or CSS selectors

BSD 3-Clause "New" or "Revised" License

1.11k stars 137 forks source link

Replace pkg_resources with packaging.version. #266

Closed wRAR closed 1 year ago

wRAR commented 1 year ago

This also solves the problem that we don't explicitly require setuptools/pkg-resources in setup.py so the module fails to import in certain minimal environments.

I wonder if this deserves 1.7.1 for that reason.

codecov[bot] commented 1 year ago

Codecov Report

Merging #266 (0a1d419) into master (53a45f1) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #266   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          138       138           
  Branches        29        29           
=========================================
  Hits           138       138

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Gallaecio commented 1 year ago

I wonder if this deserves 1.7.1 for that reason.

No opinion either way from me.