Closed Laerte closed 1 year ago
Merging #278 (c78d638) into master (26ee0c2) will increase coverage by
0.02%
. The diff coverage is100.00%
.:exclamation: Current head c78d638 differs from pull request most recent head b6893c0. Consider uploading reports for the commit b6893c0 to get more accurate results
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 90.54% 90.57% +0.02%
==========================================
Files 5 5
Lines 455 456 +1
Branches 93 93
==========================================
+ Hits 412 413 +1
Misses 32 32
Partials 11 11
Impacted Files | Coverage Δ | |
---|---|---|
parsel/selector.py | 89.50% <100.00%> (+0.03%) |
:arrow_up: |
I think str(s)
should return str(s.get())
, no shortening, no repr. That’s what repr(s) is for.
@wRAR
This is due: https://github.com/scrapy/parsel/blob/26ee0c2cc3f3085182756a7ae499d84b5f340684/parsel/selector.py#L879
I pushed the changes accordingly.
Awesome, thanks!
fix: https://github.com/scrapy/parsel/issues/275#issuecomment-1592763448, remove wrong mention of return string from docstring https://github.com/scrapy/parsel/issues/275#issuecomment-1592800253