scrapy / scrapy

Scrapy, a fast high-level web crawling & scraping framework for Python.
https://scrapy.org
BSD 3-Clause "New" or "Revised" License
51.29k stars 10.37k forks source link

Python 3 support #263

Closed extesy closed 8 years ago

extesy commented 11 years ago

Python 3 is several years old and most of packages now support it (even django!). It would be really nice to support it in scrapy as well.

redapple commented 8 years ago

Scrapy 1.1.0 is on PyPI, with Python 3 support (finally).

What took you so long?

See release notes.

Have fun!

nyov commented 8 years ago

Are we there yet? are we there yet are wethereyetarewethere — :boom: ...eh, WHAT? :sob: finally!

Congrats. Great job there keeping up the backports, @redapple. (Probably made a nice bang there, punching that "close"- button just then, right?) And Thanks, everyone.

fish-ball commented 8 years ago

Congratulations!!!!

ghost commented 8 years ago

@redapple FINALLY! thanks @ all

btw, the "PY3 95%" label is now out of date? image

kmike commented 8 years ago

@ABSmiLT no, it means 95% tests are passing in Python 3. There is a couple of features not ported yet (e.g. telnet console), and some tests are skipped. If we'd have PY2 badge it also won't be 100% according to this metric because some tests are also skipped in Python 2 :)

lothbrek commented 8 years ago

So glad to see Python 3 support. Currently writing an automation/web crawling system in Ruby but may switch to Python with the help of Scrapy!

dangra commented 8 years ago

It has been a long road, great work!

ghost commented 8 years ago

@kmike thanks a lot~ :100:

AverHLV commented 8 years ago

But what about Twisted? I can`t run my Scrapy project on python 3.5 cause of Twisted errors.

rmax commented 8 years ago

@AverHLV Twisted can run on python 3 but not on windows because _win32stdio has not been ported yet. See:

kmike commented 8 years ago

Yeah, there is an issue in Scrapy bug tracker about that: https://github.com/scrapy/scrapy/issues/1998

ghost commented 8 years ago

oops...am using python 3.5...so i have to continue waiting...loooooool

ghost commented 8 years ago

i wish i can contribute to this project ASAP...still a newbie now...

dangra commented 8 years ago

hey @ABSmiLT, try the hack suggestion in https://github.com/scrapy/scrapy/issues/1998#issuecomment-220849511 and share your experience.

ghost commented 8 years ago

@dangra okay, thanks a lot~